-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ApproachSettlement
may refer to entities without MarketID
#181
Comments
NB: Might also get the 'no MarketID' form from approaching things like "Ancient Ruins". |
Confirmed that visitor beacons trigger the event without MarketID: { "timestamp":"2022-02-18T14:33:35Z", "event":"ApproachSettlement", "Name":"Battlegroup's Disappearance", "SystemAddress":1109989017963, "BodyID":8, "BodyName":"Alioth 1 a", "Latitude":59.972752, "Longitude":-84.506294 } |
Currently 'installations' don't appear to trigger an { "timestamp":"2022-02-18T14:31:21Z", "event":"FSSSignalDiscovered", "SystemAddress":1109989017963, "SignalName":"Strategic Statistical Services" } |
Also affects Ancient Ruins, per Bravada Cadelanne @ EDCD #eddn: { "timestamp":"2022-02-18T15:02:04Z", "event":"ApproachSettlement", "Name":"$Ancient:#index=1;", "Name_Localised":"Ancient Ruins (1)", "SystemAddress":3515254557027, "BodyID":13, "BodyName":"Synuefe XR-H d11-102 1 b", "Latitude":-46.576923, "Longitude":133.985107 } |
Ancient Ruins (Odyssey): {
"timestamp": "2022-02-18T15:02:04Z",
"event": "ApproachSettlement",
"Name": "$Ancient:#index=1;",
"Name_Localised": "Ancient Ruins (1)",
"SystemAddress": 3515254557027,
"BodyID": 13,
"BodyName": "Synuefe XR-H d11-102 1 b",
"Latitude": -46.576923,
"Longitude": 133.985107
} Ancient Ruins (Horizons): {
"timestamp": "2022-02-18T15:06:45Z",
"event": "ApproachSettlement",
"Name": "$Ancient:#index=1;",
"Name_Localised": "Ancient Ruins (1)",
"SystemAddress": 3515254557027,
"BodyID": 13,
"BodyName": "Synuefe XR-H d11-102 1 b",
"Latitude": -31.788902,
"Longitude": -128.941498
} |
This has now been addressed in live code (went directly into |
e.g.
One possibility is visitor beacons. I'll confirm that shortly.
As such we will want to at least document that Senders should check for this and not send when MarketID is not set.
However...
Proposal
Allow
approachsettlement/1
messages without MarketID so as to support data about visitor beacons. Listeners should be check for if MarketID is present or not and react accordingly.The text was updated successfully, but these errors were encountered: