Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include license file #73

Closed
beckermr opened this issue May 3, 2020 · 5 comments
Closed

include license file #73

beckermr opened this issue May 3, 2020 · 5 comments

Comments

@beckermr
Copy link

beckermr commented May 3, 2020

According to the BSL-1.0, a license file needs to be shipped with the software but no such file appears in this repo. Can you please add one?

@eddelbuettel
Copy link
Owner

eddelbuettel commented May 3, 2020

Done.

Can you 'hot-fix' your tarball by adding it? I probably won't cut a new release for CRAN just to add this.

@beckermr
Copy link
Author

beckermr commented May 3, 2020

We are shipping a new release for R 4 and so will add it now. The old tarballs cannot be hot fixed.

@beckermr
Copy link
Author

beckermr commented May 3, 2020

also, thank you!

@eddelbuettel
Copy link
Owner

eddelbuettel commented May 3, 2020

Yes, sure, poor wording on my part. I didn't mean "let's rewrite history and alter published tarballs".

I meant alter your setup to (for now) use a local copy and trust me that this, as it is now committed, will be present going forward. In the Debian lingo I have worked with for 25 years, this would be part of the local diff just like your packaging meta info. But hey, you got it even though I explained like crap ;-)

Thanks for the pointer.

@beckermr
Copy link
Author

beckermr commented May 3, 2020

Ahhhhhhh! Yup! We added the license file to the conda package itself and can remove that once it appears in the source. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants