Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbranch option #61
branch option #61
Comments
I think that had come up before and there was a reason not to do it. Maybe it was mostly because 'user.github.io' webpages don't correspond to the 'github.com/user/drat' scheme. In any event one other (newer) change is worth considering too: master branch and docs/ directory. That is now permitted as an alternative. The one thing I am a little wary about is the number of different code paths over the different helper functions. We'd need at least |
|
This too is now talken care of thank to @nfultz |
|
I think an option is fine for this, but |
|
Added via #73 |
|
If you are suggesting a minimal (two file, maybe?) PR to add support for |
|
The extreme minimal changes can be made with only changing The default value still use options, so previous usage will not be interfered. |
Thanks for this terrifically useful package.
The branch that drat commits, gh-pages, is hardcoded. This is sensible in general, but for user or organization Github pages (i.e. user.github.io) Github requires those files to be stored in the master branch of a repo named user.github.io. Because of the hardcoding, it isn't possible to use drat to create a drat repo in such a Github repo.
What do you think of adding a field in insertPackage() for branch name, i.e. insertPackage(branch = "master")? Happy to add a PR.