Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfunction could get cargs argument corresponding to CFLAGS #9

Closed
jangorecki opened this issue Feb 5, 2019 · 3 comments
Closed

cfunction could get cargs argument corresponding to CFLAGS #9

jangorecki opened this issue Feb 5, 2019 · 3 comments

Comments

@jangorecki
Copy link

In the cfunction there are cppargs/cxxargs arguments that refers to CPPFLAGS/CXXFLAGS but there is no cargs that would refer to CFLAGS. FR to add that one.

@eddelbuettel
Copy link
Owner

eddelbuettel commented Feb 5, 2019

You can use CPPFLAGS to pass arguments to the C compiler. That should be good enough, no?

@jangorecki
Copy link
Author

@eddelbuettel yes it works, but it is counter intuitive.

@eddelbuettel
Copy link
Owner

eddelbuettel commented Feb 5, 2019

That is in the eye of the beholder. I (mis)used CPPFLAGS for CFLAGS for many years. We do not split preprocessor and compiler for C -- it is one call.

Changing this now would change the calling interface. I'd rather not for a small cosmetic change. I suggest we close this and move on. Moreover, all this does is set an environment variable which you could set outside of cfunction too.

My main point is there: there is no (real) functional deficiency here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants