-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we move the entrypoint script into the image? #4
Comments
Ah, I see it's already there at |
Yes, and it is a 'six of one, half a dozen of another' problem as it is good to have the autograder shipped. But if you noticed last minute that you fgorgot to include one package update in the container it is also good to call an external one. We should document both. And some of these questions are ... old. I'll try to have a pass over them too. |
Confirmed. We just need to update the questions to point the script inside the image. I think the /serverFilesCourse/datasets folder is a good example so we can leave it, although I think Nathan would prefer that large static datasets are included in the image and not passed around through serverFilesCourse (Not calling penguins.csv large, just not wanting to set a precedent where someone puts >100MB datasets in serverFilesCourse or with the question) |
Note that I talked about code, not data. I sometimes need to update the whole autograder, and "in PrairieLearn proper" is great ("it is everwhere") but I am then at the whim of a PR merge and rebuild. As I said, it is of size six both cases. Both use cases exists. |
I notice these questions source the entrypoint script from inside the course space
"entrypoint": "/grade/serverFilesCourse/r_autograder/run.sh",
Is that static enough that we could safely move a copy into the autograder image? One less thing for adopters to need to have locally, and seems to be what the other graders do.
The text was updated successfully, but these errors were encountered: