Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum DayCounter 1 says Actual360FixEd but code uses Actual365Fixed #156

Closed
klin333 opened this issue Aug 17, 2021 · 3 comments
Closed

Enum DayCounter 1 says Actual360FixEd but code uses Actual365Fixed #156

klin333 opened this issue Aug 17, 2021 · 3 comments

Comments

@klin333
Copy link
Contributor

klin333 commented Aug 17, 2021

?RQuantLib::Enum shows DayCounter = 1 to mean "Actual360FixEd", but code src/utils.cpp line 69 of master shows QuantLib::Actual365Fixed() is returned if n==1

I guess that means the documentation is wrong?

I have RQuantLib 0.4.12 installed.

@eddelbuettel
Copy link
Owner

Thanks for catching that. Maybe a documentation error. Can you reference what you see in 'src/utiles.cpp line 69'? One can fully reference this and when I look at that file I see something else:

case TIAN:

@eddelbuettel
Copy link
Owner

Oh I see, you meant 369:

rquantlib/src/utils.cpp

Lines 368 to 369 in 3b8ecb4

else if (n==1)
return QuantLib::Actual365Fixed();

I will fix the docs.

@eddelbuettel
Copy link
Owner

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants