Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0beta build error for sockets.cpp #19

Closed
dgmckelvie opened this issue Feb 11, 2017 · 1 comment
Closed

3.0beta build error for sockets.cpp #19

dgmckelvie opened this issue Feb 11, 2017 · 1 comment

Comments

@dgmckelvie
Copy link

Similar issue mentioned by MatthewButterfly:
/home/adminuser/fastcgi++/src/sockets.cpp: In member function ‘Fastcgipp::Socket Fastcgipp::SocketGroup::poll(bool)’:
/home/adminuser/fastcgi++/src/sockets.cpp:523:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if(events == pollIn)
^
/home/adminuser/fastcgi++/src/sockets.cpp:538:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
if(events == pollIn)

This is on Centos 6.8 with devtoolset-4 and cmake3 installed.

I changed both instances to use if(events & pollIn) and compile worked.
I haven't tested the binary produced but I assume it'll work as you only want to check if the EPOLLIN bits are set in the events.

@eddic
Copy link
Owner

eddic commented May 23, 2018

See issue #27

@eddic eddic closed this as completed May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants