UINavigationBar wrappers #34
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 10 11 +1
Lines 385 393 +8
==========================================
+ Hits 384 392 +8
Misses 1 1 |
| #endif | ||
|
|
||
| public typealias UnderlineStyle = NSUnderlineStyle | ||
| public typealias StrikethroughStyle = NSUnderlineStyle | ||
| public typealias ParagraphStyle = NSParagraphStyle | ||
| public typealias DrawingContext = NSStringDrawingContext |
There was a problem hiding this comment.
could we remove all these new typealiases since they're not used?
There was a problem hiding this comment.
could we remove all these new typealiases since they're not used?
I planned to use them for some new functions but then I moved them to another pull request.
| #elseif os(watchOS) | ||
| #else | ||
| import UIKit | ||
| public typealias NavigationBar = UINavigationBar |
There was a problem hiding this comment.
I don't think we need the typealias since there's no conflicting navigation bar type
| #else | ||
| extension NavigationBar { | ||
|
|
||
| public var swiftyTitleTextAttributes: [Attribute]? { |
There was a problem hiding this comment.
could you add some documentation to both of these variables? thanks 🙏
There was a problem hiding this comment.
could you add some documentation to both of these variables? thanks 🙏
Added description for these new properties, if you want you can add something better.
|
|
||
| #if os(macOS) | ||
| #elseif os(watchOS) | ||
| #else |
There was a problem hiding this comment.
I think you could just extend the above macros for the entire file so that you don't need to repeat them
|
@RomanPodymov do you have more PRs coming? If you do I'll hold off on releasing a new version and just bundle in all those changes. |
I added an extension for |
Hello.
In this pull request I added wrappers for
UINavigationBar.titleTextAttributesandUINavigationBar.largeTitleTextAttributes.Use cocoapods 1.7.0.