Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change first day of the week and time format #41

Closed
svennefenne opened this issue Sep 4, 2022 · 3 comments · Fixed by #43
Closed

Change first day of the week and time format #41

svennefenne opened this issue Sep 4, 2022 · 3 comments · Fixed by #43
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@svennefenne
Copy link

Maybe add an option to change first day of the week to monday. (Euro friendly)

Also maybe add an option to change time format to 24h. (Euro frendly)
@eddiewebb eddiewebb added enhancement New feature or request good first issue Good for newcomers labels Oct 10, 2022
@eddiewebb
Copy link
Owner

Of course, I will try to get to this soon!

@eddiewebb
Copy link
Owner

settting local of fullcalendar should do both, and we shouldbe able to mirror flarum selection.

We can also expose specific settings for firstDay and timeformat if needed

https://fullcalendar.io/docs/locale

@eddiewebb eddiewebb mentioned this issue Oct 20, 2022
Merged
@eddiewebb
Copy link
Owner

eddiewebb commented Oct 20, 2022 •
edited

@svennefenne @testm4v3rick - Fixed in 1.5.2

The plugin now uses Flarum's current locale to pass directly to fullcalendar. European locales will change date format and firstDay.

Screen Shot 2022-10-20 at 6 46 57 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support flarum local eddiewebb/flarum-calendar
2 participants
@eddiewebb @svennefenne