Fix Babel 7 compat #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @yyx990803 😀. I agree with skipping if there's no babelrc. This fixes #39 |
|
This is a breaking change, so it'll be released as a major version. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
babel-corea peer dep so that it can use whatever version ofbabel-corethe user specifies.Also removes the default
babel-preset-vue-appconfiguration - I don't think it's a good idea to hard code that in here, especially when we are going to ship a new preset with vue-cli 3.0. If the user doesn't have a.babelrc, vue-jest should just skip babel.