Fix issue parsing relative imports in stylus files #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative imports are now supported in stylus files with vue-jest
eddyerburgh
reviewed
Feb 6, 2018
lib/process.js
Outdated
| if (!stylePart) return {} | ||
|
|
||
| let cssCode = stylePart.content | ||
| if (/^styl|stylus$/.test(stylePart.lang)) { | ||
| const vuePath = join(path, '..') |
There was a problem hiding this comment.
Can you use process.cwd for the path? Like in vueify—https://github.com/vuejs/vueify/blob/master/lib/compilers/stylus.js#L14
eddyerburgh
requested changes
Feb 6, 2018
Also rename path variables to filePath to avoid confusion
|
Thanks for taking a look, I also changed the directory resolution to be clearer. And as a result renamed the path variables to filePath to avoid confusion. |
eddyerburgh
approved these changes
Feb 8, 2018
|
Thanks 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #52