-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash preparing application config if Symbol is missing #31
Comments
I'm curious what that scenario might be. Are you running without tapestry-core? |
We are running Tests with TynamoTest and Tapestry TestRunner which go around TapestryFilter and the initialization of the EXECUTION_MODE symbol (https://github.com/apache/tapestry-5/blob/master/tapestry-core/src/main/java/org/apache/tapestry5/TapestryFilter.java#L91) Since the tapestry-react module provides an 'Tapestry-Module-Classes' entry in MANIFEST.MF, the ReactModule is being loaded and the Symbol tapestry.execution-mode can not be resolved. |
Thanks for the explanation. I'm not sure where and how this should be fixed. Someone should probably set |
I still think that |
Hi,
in some scenarios when not all symbols are available the ReactModule might crash trying to contribute the application config.
Symbols:
https://github.com/eddyson-de/tapestry-react/blob/master/src/main/java/de/eddyson/tapestry/react/ReactModule.java#L119-L121
Crashing line:
https://github.com/eddyson-de/tapestry-react/blob/master/src/main/java/de/eddyson/tapestry/react/ReactModule.java#L122
Already working on a pull request.
The text was updated successfully, but these errors were encountered: