Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript upgrade #5

Closed
brewsoftware opened this issue Nov 23, 2016 · 2 comments
Closed

Typescript upgrade #5

brewsoftware opened this issue Nov 23, 2016 · 2 comments

Comments

@brewsoftware
Copy link

Hey, just a question.

Do you think you would be interested in upgrading this to Typescript?

I'm kind of a stickler for TS and would love to see this example at least follow the TS pattern where it can.

Cheers,
Jason - BrewSoftware

@eddyystop
Copy link
Owner

Thanks for asking.

This is a starter package for where I work. TS isn't used here as we want to avoid a build step for the server code.

You can always fork it if you have to, but then be aware:

feathers-hooks-common went from this repo to feathers core. feathers-services-verify-reset is moving into core as feathers-authentication-management having been refactored and getting new features. feathers-reduxify-services might one day move into core, though its arguable whether its within feathers stated purpose.

Interested people might push TS defns for these as they have for other parts of feathers.

@brewsoftware
Copy link
Author

No problem, thanks for the context. I think we can leave it out.

Yer I've just jumped on feathers as an experiment so not that familiar with the ecosystem yet. Redux stuff doesn't belong in the core but the rest does.

Thanks for the example. If it think of anything else I will let you know.

Cheers,
Jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants