Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload request method is not respected on iOS #158

Closed
edeckers opened this issue Jul 27, 2021 · 0 comments · Fixed by #159
Closed

Upload request method is not respected on iOS #158

edeckers opened this issue Jul 27, 2021 · 0 comments · Fixed by #159
Labels
bug Something isn't working iOS
Projects
Expedited
Milestone
2.0.4

Comments

@edeckers
Copy link
Owner

edeckers commented Jul 27, 2021 •
edited

Describe the bug
Originally reported by @vforvasile in #156.

The provided request method (HTTP verb) is not respected on iOS.

To Reproduce
Steps to reproduce the behavior:

  1. Start an upload from an iOS device with any method but POST
  2. Check the access logs of the server and notice that regardless of the chosen method, data is received as a POST message

Expected behavior
The provided request method is used in the iOS code base, so the second reproduction step will show the actual chosen method.

Smartphone (please complete the following information):

  • Device: all iOS
  • OS: all iOS
  • Browser: not applicable
  • Version: all

Additional context
The location of the actual hard coded method:

react-native-blob-courier/ios/Upload/BlobUploader.swift

Line 26 in 1049b4e

request.httpMethod = "POST"

@edeckers edeckers added the bug Something isn't working label Jul 27, 2021
@edeckers edeckers added this to the 1.1.3 milestone Jul 27, 2021
@edeckers edeckers mentioned this issue Jul 27, 2021
Closed
@edeckers edeckers linked a pull request Aug 21, 2021 that will close this issue
fix: http method not respected in iOS upload #159
Merged
2 tasks
@edeckers edeckers added this to In progress in Expedited Aug 22, 2021
@edeckers edeckers added the iOS label Aug 22, 2021
@edeckers edeckers modified the milestones: 2.0.3, 2.0.4 Aug 23, 2021
Expedited automation moved this from In progress to Done Aug 23, 2021
@edeckers edeckers mentioned this issue Aug 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working iOS
Projects
Expedited
Done
Milestone
2.0.4
Development

Successfully merging a pull request may close this issue.

fix: http method not respected in iOS upload edeckers/react-native-blob-courier
1 participant
@edeckers