Use consistent register names where free, and make trampoline its own function #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any reason for the filling drop? That pointer can't possibly be read from again, afaict. |
|
Eh sanity checking. I could make it a debug build thing or just revert it. |
|
Which would you like me to do / any other concerns with this? |
|
Ping. I've managed to upstream all my other forks for my toy OS. Fringe is the last one :). |
|
Pong. Still super busy, sorry :( |
|
Understood, thanks for at least finding the time to say so :). |
|
Oh, and it has conflicts now so I should fix that. |
Ericson2314
force-pushed
the
master
branch
3 times, most recently
from
61e17d0
to
414fd37
Compare
Ericson2314
changed the title
|
Ok, removed the filling drop, and fix the alignment issues; this should be good to go! The build failure is due to a bug (the thing I opened and closed the recent PR for) in nightly, "2016-06-13" at least works. |
Ericson2314
force-pushed
the
master
branch
7 times, most recently
from
452cfe0
to
4c6df41
Compare
Ericson2314
changed the title
Ericson2314
force-pushed
the
master
branch
2 times, most recently
from
891f176
to
5c35578
Compare
The exception to this is %eax is used not %edi on x86 because its caller-save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, now things get interesting. These changes don't affect the context interface at all, but change the assembly such that I can do my parameter/coroutine stuff too. I hope after this to refactor that work so it can be added to this crate without touching the context interface interfaces.
Feel free to ask any questions about why things are changed the way they are, of course :).