Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_url_params: switch key/value in dict to have a more "natural" direction? #51

Open
nerdoc opened this issue Jul 1, 2023 · 1 comment

Comments

@nerdoc
Copy link
Contributor

nerdoc commented Jul 1, 2023

As a newcomer, I maybe don't understand fully the ideas behind your intentions, but sometimes may have a fresh view to the scene.

I wonder why in _url_params, the key is the local variable, and the value the URL GET parameter.

As it is called "_url_param", I would expect it to be the pother way round: the keys should be the url params that are the "source" of the value, and the values of the dict should be the name of the local vars.

I always have to think outside the box when I create _url_params, they don't feel naturally.

Yes, I am aware that this would break things in the first place, but I think reactor is still in a state wher this could be easily changed without hitting 1000s of installations.... yet 😆

What do you say?

@edelvalle
Copy link
Owner

Because you pointed out this and I tried to use. I found out it was not the best solution and tried a new approach, check if you like it better: 517aece

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants