Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename data to keys #88

Closed
edemaine opened this issue Aug 24, 2022 · 0 comments
Closed

Rename data to keys #88

edemaine opened this issue Aug 24, 2022 · 0 comments
Labels
api breaking Breaking change for next major version

Comments

@edemaine
Copy link
Owner

edemaine commented Aug 24, 2022

Currently, Drawing has an attribute called data which is an array of arrays of key strings. This name is pretty generic. keys seems more natural. (tiles should probably be reserved for the corresponding array of arrays of built Tile objects.)

This would be a breaking API change, so maybe for v3.

This breaks some symmetry. Currently both Mapping and Drawing objects have a data attribute. But they mean very different things, so should probably be renamed to map and keys respectively. And Style already doesn't have data; it uses css.

@edemaine edemaine added breaking Breaking change for next major version api labels Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api breaking Breaking change for next major version
Projects
None yet
Development

No branches or pull requests

1 participant