Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expiration timeout for committed offsets #594

Closed
FDePourcq opened this issue Mar 31, 2016 · 4 comments
Closed

expiration timeout for committed offsets #594

FDePourcq opened this issue Mar 31, 2016 · 4 comments

Comments

@FDePourcq
Copy link

Context: the kafka server will keep a committed offset by default for a duration of offsets.retention.minutes .
The protocol allows the clients to specify a RetentionTime per OffsetCommitRequest
https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol
Currently librdkafka does not offer a way to specify this RetentionTime to the user.

Feature: Somehow offer a way to configure the RetentionTime be it globally be it per topic be it per partition, or even as a parameter to rd_kafka_commit.

@edenhill edenhill added this to the 0.9.2 milestone Apr 11, 2016
@edenhill edenhill modified the milestones: Cuaba, 0.9.2 Sep 29, 2016
@edenhill edenhill modified the milestones: 0.9.3, 0.9.4 Feb 10, 2017
@edenhill edenhill modified the milestones: 0.9.5, 0.9.4 Mar 3, 2017
@edenhill
Copy link
Contributor

edenhill commented Mar 8, 2017

The most flexible approach would be for an argument to commit...(), but that's also the biggest change.

Would you be fine with a global configuration property?

@FDePourcq
Copy link
Author

Oh hoi! Good to hear from you! Though I'm not pushing for this feature,
It is up to you to decide how much code (rd_kafka_op_s, rd_kafka_commit0, rd_kafka_commit) you want to defile with that additional int64 :)

It would only be a problem for processes with multiple consumers and each of those consumers having different stringent requirements on commit-offset-retention. Looks as if a global configuration option would be fine for the coming years.

@edenhill
Copy link
Contributor

edenhill commented Mar 8, 2017

Great! (The global config is per consumer instance though, not per process)

@edenhill edenhill modified the milestone: next feature Jun 29, 2017
@edenhill
Copy link
Contributor

edenhill commented Jan 4, 2018

The per-commit timestamp/timeout has been removed from later versions of the protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants