Revert transaction.timeout.ms change #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a0f7546.
This is a quick fix, what we really want to do is differentiate between non-debug logs and error propagation, they are currently the same thing.
mhowlett
reviewed
Jan 4, 2021
| @@ -29,11 +29,6 @@ librdkafka v1.6.0 is feature release: | |||
| supported on Apache Kafka 2.5 or later, on earlier releases you will | |||
| need to use one producer per input partition for EOS. This limitation | |||
| is not enforced by the producer or broker. | |||
| * The default for the producer configuration property | |||
There was a problem hiding this comment.
i assume this change is with good reason, but i guess i should check what that is since it apparently deviates from the java implementation.
mhowlett
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the KIP-447 recommendation to reduce transaction.timeout.ms is no longer true.