Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks (mostly in tests) #4067

Merged
merged 6 commits into from Nov 24, 2022
Merged

Fix memory leaks (mostly in tests) #4067

merged 6 commits into from Nov 24, 2022

Conversation

edenhill
Copy link
Contributor

Seems ASAN stopped reporting leaks properly, these are from valgrind runs.

@edenhill edenhill requested a review from emasab November 21, 2022 07:53
emasab
emasab approved these changes Nov 24, 2022
View reviewed changes
Copy link
Collaborator

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edenhill edenhill merged commit 33fee4c into master Nov 24, 2022
@edenhill edenhill deleted the leaks20221121 branch November 24, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edenhill @emasab