Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not use strokes? #34

Closed
proimage opened this issue Apr 19, 2017 · 4 comments
Closed

Why not use strokes? #34

proimage opened this issue Apr 19, 2017 · 4 comments

Comments

@proimage
Copy link

A number of the icons (PDF, RSS, Wire, etc) could be represented in fewer bytes by applying a stroke to a path, instead of it being an outlined and enclosed shape. Any particular reason why this hasn't been done?

@edent
Copy link
Owner

edent commented Apr 20, 2017

The reason is... I'm still learning about SVG ☺️😊😀😁😁

If strokes will make them smaller - go for it! Submit a pull request and let's save the world a few more bytes!

@RazrFalcon
Copy link
Collaborator

At least PDF icon can't be done like this.

@proimage
Copy link
Author

proimage commented Apr 20, 2017

At least PDF icon can't be done like this.

Oh?

<svg viewBox="0 0 512 512" xmlns="http://www.w3.org/2000/svg">
<rect fill="#f00" height="512" rx="15%" width="512"/>
<path d="m 257,109 c -2,-62 -50,-47 -48,11 3,70 29,90 68,139 49,62 86,97 116,105 45,12 70,-26 26,-45 -43,-19 -122,-13 -167,-6 -74,12 -127,33 -168,79 -36,40 -4,70 32,35 33,-31 77,-116 95,-156 24,-53 51,-100 46,-168 z" style="fill:none;stroke:#fff;stroke-width:27"/>
</svg>

391 bytes instead of 635 bytes.

@RazrFalcon
Copy link
Collaborator

You right. I thought it will look too wavy.

Can you send a pull request with this icon? But remove style attribute.

@edent edent closed this as completed in 532b741 Apr 30, 2017
romain-dartigues pushed a commit to romain-dartigues/SuperTinyIcons that referenced this issue Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants