Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded redirection (PDK progress indicator) #20

Closed
bittner opened this issue May 10, 2018 · 6 comments
Closed

Remove unneeded redirection (PDK progress indicator) #20

bittner opened this issue May 10, 2018 · 6 comments

Comments

@bittner
Copy link
Contributor

bittner commented May 10, 2018

The redirection of output to stderr can now simply be removed, i.e. use code like this:

- stage: validate
  script: pdk validate

- stage: test
  script: pdk test unit

See puppetlabs/pdk#323 (comment) for reference.

@edestecd
Copy link
Owner

the new templates in pdk no longer use pdk in travis.

@bittner
Copy link
Contributor Author

bittner commented May 11, 2018

Alright. 🤔

If the CI configuration proposed by Puppet Lab looks like this (aka "hard to memorize") we should probably do something about it.

@bittner
Copy link
Contributor Author

bittner commented May 11, 2018

the new templates in pdk no longer use pdk in travis.

They probably never did in the past.

@edestecd
Copy link
Owner

Yea that's the one. We use the stock PDK templates from that repo.
We have discussed using PDK in our travis builds, but at this point I'm happy to just have a tool that can manage all those files I'm sick of syncing across all our modules ;)

@edestecd
Copy link
Owner

Its updated to use version 1.5.0 of the pdk templates. Did we need anything else here?

@bittner
Copy link
Contributor Author

bittner commented May 23, 2018

Well, it's @puppetlab's turn now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants