Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support userActivationSettings parameter in RPC method activate_survey #1026

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

Copy link

trunk-io bot commented Nov 9, 2023

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@edgarrmondragon edgarrmondragon force-pushed the feat/activate-survey-user-activation-settings branch 2 times, most recently from 9cf09b1 to 6c67feb Compare November 9, 2023 22:55
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ddeedc) 100.00% compared to head (d835574) 100.00%.

❗ Current head d835574 differs from pull request most recent head 871f97d. Consider uploading reports for the commit 871f97d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1026   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          434       435    +1     
  Branches        23        24    +1     
=========================================
+ Hits           434       435    +1     
Flag Coverage Δ
integration 90.57% <100.00%> (+0.02%) ⬆️
unit 92.87% <75.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the feat/activate-survey-user-activation-settings branch 5 times, most recently from aab638c to 313dd0e Compare November 10, 2023 23:47
@edgarrmondragon edgarrmondragon added the Release Package version bump label Nov 10, 2023
@edgarrmondragon edgarrmondragon force-pushed the feat/activate-survey-user-activation-settings branch 3 times, most recently from 400020c to 853ee80 Compare November 14, 2023 18:13
@edgarrmondragon edgarrmondragon force-pushed the feat/activate-survey-user-activation-settings branch from 853ee80 to d835574 Compare November 15, 2023 05:15
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 15, 2023 19:27
@edgarrmondragon edgarrmondragon merged commit 93e9379 into main Nov 15, 2023
61 of 63 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/activate-survey-user-activation-settings branch November 15, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Package version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant