Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix some type annotations and docs #643

Merged
merged 4 commits into from Dec 19, 2022
Merged

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Dec 15, 2022


📚 Documentation preview 📚: https://citric--643.org.readthedocs.build/en/643/

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (035ef7d) compared to base (a02d06f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #643   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          334       335    +1     
  Branches        21        21           
=========================================
+ Hits           334       335    +1     
Impacted Files Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)
src/citric/session.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 19, 2022 22:33
@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon merged commit f803ee4 into main Dec 19, 2022
@edgarrmondragon edgarrmondragon deleted the chore/fix-types branch December 19, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant