Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use a dedicated RPCInterfaceNotEnabledError exception when a disabled JSON Interface is detected #687

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Jan 27, 2023


📚 Documentation preview 📚: https://citric--687.org.readthedocs.build/en/687/

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b71d9d0) compared to base (1705bac).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b71d9d0 differs from pull request most recent head 2edd79d. Consider uploading reports for the commit 2edd79d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #687   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          329       332    +3     
  Branches        20        20           
=========================================
+ Hits           329       332    +3     
Impacted Files Coverage Δ
src/citric/session.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edgarrmondragon edgarrmondragon merged commit 3785e21 into main Jan 27, 2023
@edgarrmondragon edgarrmondragon deleted the rpc-disabled-exception branch January 27, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant