Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error message when RPC response is not valid JSON #732

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Mar 3, 2023

Closes #731


📚 Documentation preview 📚: https://citric--732.org.readthedocs.build/en/732/

@edgarrmondragon edgarrmondragon linked an issue Mar 3, 2023 that may be closed by this pull request
@trunk-io
Copy link

trunk-io bot commented Mar 3, 2023

🚫 This pull request was closed and has been removed from the merge queue (details).

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (1649185) 100.00% compared to head (6cc1d11) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #732   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          332       343   +11     
  Branches        20        20           
=========================================
+ Hits           332       343   +11     
Impacted Files Coverage Δ
src/citric/exceptions.py 100.00% <100.00%> (ø)
src/citric/session.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@edgarrmondragon edgarrmondragon force-pushed the 731-bug-improve-error-message-when-rpc-response-is-not-valid-json branch from cf44aad to 6cc1d11 Compare March 3, 2023 01:40
@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon merged commit c81c4a6 into main Mar 3, 2023
@edgarrmondragon edgarrmondragon deleted the 731-bug-improve-error-message-when-rpc-response-is-not-valid-json branch March 3, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Improve error message when RPC response is not valid JSON
1 participant