Finalizer #3
Merged
Finalizer #3
+261
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theodus
approved these changes
Jul 20, 2021
| cmp: &Option<Result<T, Closed>>, | ||
| cx: &mut Context, | ||
| ) { | ||
| ) -> Option<Result<T, Closed>> { |
src/eventual/change.rs
Outdated
| let value = mem::replace(lock.deref_mut(), ChangeVal::None); | ||
|
|
||
| match value { | ||
| // If there is a new value and it is different than our prevously |
There was a problem hiding this comment.
Suggested change
| // If there is a new value and it is different than our prevously | |
| // If there is a new value and it is different than our previously |
src/eventual/change.rs
Outdated
| ChangeVal::Finalized(finalized) => { | ||
| // Verify that it's not copying the final value over again | ||
| // because in racey situations it may have been copied once | ||
| // then had the value consumed. It would't be the end of the |
There was a problem hiding this comment.
Suggested change
| // then had the value consumed. It would't be the end of the | |
| // then had the value consumed. It wouldn't be the end of the |
| @@ -38,12 +38,8 @@ where | |||
| // the future that would produce values. But... that may be very complex. A | |||
There was a problem hiding this comment.
Line above: "desireble" -> "desirable"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main update here is that subscriptions can always observe the final value even if the eventual is closed. This makes a lot more sense than what was happening before (at the expense of some terribly messy internal code).
Also added docs, some minor APIs, and a bump to 0.3.0. I think this should be the last update before putting this to use.