Skip to content
This repository has been archived by the owner on Sep 28, 2020. It is now read-only.

A lovely swagger API :) #75

Closed
marcoherbst opened this issue Dec 13, 2017 · 3 comments
Closed

A lovely swagger API :) #75

marcoherbst opened this issue Dec 13, 2017 · 3 comments
Assignees
Milestone

Comments

@marcoherbst
Copy link
Collaborator

marcoherbst commented Dec 13, 2017

We discussed this for Evercam.
One of the reasons you're doing this is to learn how swagger (now OpenAPI) works and how it can be done really nicely...

The API endpoints will be api.edgecommander.com/v1/....

Think carefully about how you want them to look, this can easily be done badly.

@marcoherbst marcoherbst added this to the v5 Long Finger milestone Dec 13, 2017
@marcoherbst marcoherbst modified the milestones: v5 Long Finger, January Jan 17, 2018
@Ali7862 Ali7862 modified the milestones: January, February Feb 6, 2018
@ijunaid8989
Copy link
Member

This is not an API. it's an application which connecting all its method to itself. not serving as a third-party tool as well.

I don't see any need of Swagger for this. Unless we make it have one.
e.g create user api keys, change the structure to separate usual methods and API endpoint (for creating an NVR, Command, SITE, Router, SMS). Mostly swagger is a face to hidden skeletons, We already have an interface to all our methods. It will be a waste of time to make a separate interface to connect with it.

@marcoherbst
Copy link
Collaborator Author

@Ali7862 close this issue?

@Ali7862
Copy link
Collaborator

Ali7862 commented Feb 19, 2018

It's done.

@Ali7862 Ali7862 closed this as completed Feb 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants