Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Open Ethnographer annotations refer to post revisions #6

Closed
tanius opened this issue Nov 1, 2017 · 1 comment
Closed

Make Open Ethnographer annotations refer to post revisions #6

tanius opened this issue Nov 1, 2017 · 1 comment

Comments

@tanius
Copy link
Member

tanius commented Nov 1, 2017

Currently, Open Ethnographer annotations refer to posts, by post ID (example).

This creates problems when the post is edited after the annotation has been created. Namely, the XPath anchoring mechanism to refer to the first and last word of an annotation's quote text may not be able to anchor the XPath expressions to the new version of the post. This can usually be fixed by trying to find the quote text in the new version of the post, but that is not guaranteed to succeed and may need manual intervention (as we experienced).

This issue only happens rarely, as coding happens usually weeks after posts have been written, and post are usually not edited by their original authors then anymore. However, to have a well thought-through architecture, it makes sense to solve this in the medium term.

For that, Open Ethnographer annotations would also refer to a specific revision and not only to a specific post. Since revisions cannot be deleted in Discourse (they can only be "hidden" but admins can still see them), that is a robust approach.

@tanius tanius changed the title Make Make Open Ethnographer annotations refer to post revisions Nov 1, 2017
@tanius tanius transferred this issue from edgeryders/discourse Sep 4, 2019
@damingo
Copy link
Member

damingo commented Feb 18, 2022

Done. If a post is now edited after it was annotated all annotations will refer to the revision prior to the edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants