Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that the [text-direction=rtl] tag does not work below Markdown lists #92

Open
tanius opened this Issue Aug 28, 2017 · 0 comments

Comments

1 participant
@tanius
Copy link
Member

commented Aug 28, 2017

Currently, the [text-direction=rtl] … [/text-direction] tag will not have any effect on the "cooked HTML" output of Discourse (so, no right-aligning) if it follows directly after a Markdown list, like this:

* Markdown list item 1
* Markdown list item 2
[text-direction=rtl]
تحدثنا مروة حسن
[/text-direction]

It will however work when separating it from the Markdown list with an empty line, like this:

* Markdown list item 1
* Markdown list item 2

[text-direction=rtl]
تحدثنا مروة حسن
[/text-direction]

This should not be required, as whitespace-significant markup or programming languages are confusing and not intuitive. Markdown itself is whitespace significant (newline for a paragraph etc.), but any tags should take higher priority.

If necessary, an implementation could be to pre-process the text and add the "missing" empty lines where needed.

@tanius tanius added this to the (3) Later fixes milestone Aug 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.