Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should treatment and control size be switched when using get_treat_size? #2

Closed
bpark738 opened this issue Feb 15, 2020 · 0 comments
Closed

Comments

@bpark738
Copy link

In the utils, get_treat_size function is defined to be

def get_treat_size(t, treat_split=0.5):

num_treatment = t[t > treat_split].shape[0]
num_control = t[t <= treat_split].shape[0]

return num_treatment, num_control

But in the CTL.py code , it looks like its used like this:

tb_num_cont, tb_num_treat = get_treat_size(train_treat1)

where I think cont indicates control and treat indicates treated.

Shouldn't it be

tb_num_treat, tb_num_cont= get_treat_size(train_treat1)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants