Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Extend tests #50

Closed
martialblog opened this issue Aug 29, 2016 · 3 comments
Closed

Refactor/Extend tests #50

martialblog opened this issue Aug 29, 2016 · 3 comments

Comments

@martialblog
Copy link
Contributor

Hi,

I've updated the test a little bit and added an acceptance test. Had some issues with testing the Master installation in Travis CI, so only the client is currently tested. However it should be easy to extend the tests in the future.

https://github.com/martialblog/puppet-module-kerberos/tree/refactor_tests

This is based on my previous Pull Request, so it's best to wait until it's merged and then I'm gonna rebase.

Feedback is welcome.
Cheers

@edgester
Copy link
Owner

The branch looks good to me.

@martialblog
Copy link
Contributor Author

Alright, so I'm gonna try to get a running beaker test for the master this week. Otherwise I think it's better than nothing.

https://github.com/martialblog/puppet-module-kerberos/commit/735005330ddd4a26445359c64acac52819772431

@edgester
Copy link
Owner

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants