Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings support for provisionwatchers #30

Closed
tonyespy opened this issue Aug 14, 2018 · 6 comments · Fixed by #423
Closed

Add settings support for provisionwatchers #30

tonyespy opened this issue Aug 14, 2018 · 6 comments · Fixed by #423
Assignees
Labels
enhancement New feature or request geneva medium

Comments

@tonyespy
Copy link
Member

Dynamically create provisionwatcher instances based on configuration settings so that device services can implement dynamic discovery.

For more details see the Device Services functional requirements document.

Estimated effort: 3d

@tonyespy tonyespy added enhancement New feature or request medium labels Aug 14, 2018
@jduranf
Copy link
Contributor

jduranf commented Feb 11, 2019

If it's fine, I will work on it

@cloudxxx8
Copy link
Member

Sure, thank you very much

@tonyespy
Copy link
Member Author

Let's discuss this. I'd prefer for someone to review the original design and document it before we re-implement in Go. For one, I think requiring an endpoint for discovery is overkill, as it'd require the use of the support scheduler. Instead, it'd be simple to add a scan interval to the SDK, so that the DS could be configured to use a sensible interval and the SDK itself would schedule the required polling.

@jduranf
Copy link
Contributor

jduranf commented Feb 15, 2019

If I'm not wrong, the idea of this issue it to implement the provision system, the cache system and the callback system.
After that, in #29 should be implemented the discover logic, which can be done implementing an endpoint or/and a scan interval to the SDK (for flexibility, maybe should be better to have both options)

@cloudxxx8
Copy link
Member

@jduranf agree, they should be implemented together

@tonyespy tonyespy added the fuji label Feb 18, 2019
@tonyespy
Copy link
Member Author

We discussed during today's WG meeting and it was decided to defer SDK-based dynamic device discovery to Fuji. It was felt that someone should review the original design first, and expand the design to also cover black-listing, before we implement anything.

It also should be noted that a DS can implement dynamic device discovery on its own with both C and Go SDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request geneva medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants