Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Unit of Measure (UoM) ADR #3957

Closed
cloudxxx8 opened this issue Apr 10, 2022 · 3 comments · Fixed by #4127
Closed

Implement Unit of Measure (UoM) ADR #3957

cloudxxx8 opened this issue Apr 10, 2022 · 3 comments · Fixed by #4127
Assignees
Labels
1-low priority denoting isolated changes enhancement New feature or request levski fall 2022 release
Projects
Milestone

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core-metadata

Description [REQUIRED]

Implement the design in the ADR
https://docs.edgexfoundry.org/2.2/design/adr/core/0022-UoM/
GET /api/v2/uom
In addition, I suggest to add a GET API to retrieve the current UoM settings. It will just load the UoMFile and return the content.
Also, use the Accept header to determine whether the API should return JSON or TOML format.
Ref: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept

Furthermore, the Values of UoM should be String array
Values=["lbs", "ounces", "kilos", "grams"]
not
Values="lbs,ounces,kilos,grams"

@cloudxxx8 cloudxxx8 added enhancement New feature or request levski fall 2022 release labels Apr 10, 2022
@cloudxxx8 cloudxxx8 added this to the Levski milestone Apr 10, 2022
@cloudxxx8 cloudxxx8 added this to New Issues in Core WG via automation Apr 10, 2022
@JamesKButcher
Copy link
Contributor

Moving to icebox because not happening for Kamakura

@JamesKButcher JamesKButcher moved this from New Issues to Icebox in Core WG Apr 21, 2022
@cloudxxx8 cloudxxx8 moved this from Icebox to New Issues in Core WG Jul 5, 2022
@cloudxxx8 cloudxxx8 added the 1-low priority denoting isolated changes label Jul 5, 2022
@cloudxxx8 cloudxxx8 moved this from New Issues to Release Backlog in Core WG Jul 5, 2022
@cloudxxx8
Copy link
Member Author

move to release backlog for levski

@cloudxxx8 cloudxxx8 assigned chr1shung and unassigned jinlinGuan Jul 27, 2022
@cloudxxx8 cloudxxx8 moved this from Release Backlog to In progress in Core WG Aug 3, 2022
@cloudxxx8
Copy link
Member Author

@hahattan in the Core working group today, we decided to implement the GET API for this issue

Core WG automation moved this from In progress to Levski Done Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-low priority denoting isolated changes enhancement New feature or request levski fall 2022 release
Projects
No open projects
Core WG
  
Levski Done
Development

Successfully merging a pull request may close this issue.

4 participants