Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add go-winio to attribution (new SPIFFE dependency) #4029

Merged
merged 1 commit into from
May 23, 2022
Merged

feat: Add go-winio to attribution (new SPIFFE dependency) #4029

merged 1 commit into from
May 23, 2022

Conversation

bnevis-i
Copy link
Collaborator

Signed-off-by: Bryon Nevis bryon.nevis@intel.com

This PR is necessary to make #4000 mergeable.

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

New dependency is being introduced by go-spiffe, which is approved.

@jim-wang-intel
Copy link
Contributor

new from version 2.1?

@bnevis-i
Copy link
Collaborator Author

new from version 2.1?

Yes. Can't apply dependabot update without it.

jim-wang-intel
jim-wang-intel previously approved these changes May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #4029 (35aeb34) into main (87560f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4029   +/-   ##
=======================================
  Coverage   47.20%   47.20%           
=======================================
  Files         114      114           
  Lines        9832     9832           
=======================================
  Hits         4641     4641           
  Misses       4804     4804           
  Partials      387      387           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87560f2...35aeb34. Read the comment docs.

@bnevis-i
Copy link
Collaborator Author

recheck

@farshidtz
Copy link
Member

The snap build issue has been resolved by #4035. Please ignore the failed check.

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@bnevis-i bnevis-i merged commit ba7dda9 into edgexfoundry:main May 23, 2022
@bnevis-i bnevis-i deleted the bnevis-i/go-winio branch May 23, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants