Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change redis username from redis5 to default #4031

Merged
merged 2 commits into from
May 24, 2022

Conversation

vli11
Copy link
Contributor

@vli11 vli11 commented May 20, 2022

FIXES: #3860

Signed-off-by: Valina Li valina.li@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@vli11 vli11 marked this pull request as draft May 20, 2022 03:47
@bnevis-i bnevis-i marked this pull request as ready for review May 20, 2022 03:49
@codecov-commenter
Copy link

Codecov Report

Merging #4031 (702d8bd) into main (87560f2) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #4031   +/-   ##
=======================================
  Coverage   47.20%   47.20%           
=======================================
  Files         114      114           
  Lines        9832     9832           
=======================================
  Hits         4641     4641           
  Misses       4804     4804           
  Partials      387      387           
Impacted Files Coverage Δ
internal/security/secretstore/init.go 17.12% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87560f2...702d8bd. Read the comment docs.

internal/security/secretstore/init.go Outdated Show resolved Hide resolved
 FIXES: edgexfoundry#3860

Signed-off-by: Valina Li <valina.li@intel.com>
bnevis-i
bnevis-i previously approved these changes May 20, 2022
@farshidtz
Copy link
Member

The snap build issue has been resolved by #4035. Please ignore the failed check or rebase.

Signed-off-by: Valina Li <valina.li@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell added this to QA/Code Review in Security WG May 23, 2022
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit 4c16504 into edgexfoundry:main May 24, 2022
Security WG automation moved this from QA/Code Review to Done May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working levski fall 2022 release security-services
Projects
Security WG
  
Done
Development

Successfully merging this pull request may close these issues.

"redisdb" secret incorrectly states username for redis is "redis5"
7 participants