Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Optimize test-attribution-txt.sh to use go.mod, not vendor #4059

Merged

Conversation

lenny-goodell
Copy link
Member

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?) N/A
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

New Dependency Instructions (If applicable)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #4059 (a579259) into main (a33d295) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4059   +/-   ##
=======================================
  Coverage   47.25%   47.25%           
=======================================
  Files         114      114           
  Lines        9846     9846           
=======================================
  Hits         4653     4653           
  Misses       4805     4805           
  Partials      388      388           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a33d295...a579259. Read the comment docs.

Copy link
Contributor

@ernestojeda ernestojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 25cc1d4 into edgexfoundry:main Jun 22, 2022
@lenny-goodell lenny-goodell deleted the optimize-test-attribution branch June 22, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants