Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(command): update core-command to support message bus access #4129

Merged
merged 1 commit into from
Aug 29, 2022
Merged

feat(command): update core-command to support message bus access #4129

merged 1 commit into from
Aug 29, 2022

Conversation

chr1shung
Copy link
Member

@chr1shung chr1shung commented Aug 22, 2022

dependent on edgexfoundry/go-mod-bootstrap#365

fix #4073
fix #4074

Signed-off-by: Chris Hung chris@iotechsys.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) wait until whole implementation is finished

Testing Instructions

  1. Run core-command from this branch with MESSAGEQUEUE_REQUIRED=true environment variable
  2. Verified the service is bootstrapped and connected to the messagebus:
...
level=INFO ts=2022-08-24T08:33:58.200388038Z app=core-command source=clients.go:147 msg="Using registry for URL for 'core-metadata': http://edgex-core-metadata:59881"
level=INFO ts=2022-08-24T08:33:58.200440505Z app=core-command source=messaging.go:69 msg="Setting options for secure MessageBus with AuthMode='usernamepassword' and SecretName='redisdb"
level=INFO ts=2022-08-24T08:33:58.200527048Z app=core-command source=messaging.go:104 msg="Connected to redis Message Bus @ redis://edgex-redis:6379 publishing on '' prefix topic with AuthMode='usernamepassword'"
level=INFO ts=2022-08-24T08:33:58.202249217Z app=core-command source=externalmqtt.go:151 msg="Connected to external MQTT broker @ tcp://mqtt-broker:1883 with AuthMode='none'"
level=INFO ts=2022-08-24T08:33:58.202467796Z app=core-command source=telemetry.go:86 msg="Telemetry starting"
level=INFO ts=2022-08-24T08:33:58.202532216Z app=core-command source=httpserver.go:132 msg="Web server starting (edgex-core-command:59882)"
level=INFO ts=2022-08-24T08:33:58.202563173Z app=core-command source=message.go:50 msg="Service dependencies resolved..."
level=INFO ts=2022-08-24T08:33:58.202572327Z app=core-command source=message.go:51 msg="Starting core-command 0.0.0 "
level=INFO ts=2022-08-24T08:33:58.202576921Z app=core-command source=message.go:55 msg="This is the Core Command Microservice"
level=INFO ts=2022-08-24T08:33:58.202587394Z app=core-command source=message.go:58 msg="Service started in: 6.296039193s"

New Dependency Instructions (If applicable)

cmd/core-command/res/configuration.toml Show resolved Hide resolved
internal/core/command/config/config.go Show resolved Hide resolved
internal/core/command/config/config.go Outdated Show resolved Hide resolved
internal/core/command/config/config.go Outdated Show resolved Hide resolved
internal/core/command/main.go Outdated Show resolved Hide resolved
lenny-goodell
lenny-goodell previously approved these changes Aug 25, 2022
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell
Copy link
Member

@hahattan , look like you need to run make tidy and commit the updated go.sum file.

@chr1shung
Copy link
Member Author

@hahattan , look like you need to run make tidy and commit the updated go.sum file.

sure dependent on the fininsh of edgexfoundry/go-mod-bootstrap#365

@lenny-goodell
Copy link
Member

sure dependent on the fininsh of edgexfoundry/go-mod-bootstrap#365

Right, for some reason I thought that got merged. I have approved and merged it. :-)

@chr1shung chr1shung marked this pull request as ready for review August 26, 2022 01:37
Signed-off-by: Chris Hung <chris@iotechsys.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit fd31c87 into edgexfoundry:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants