Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): add secure mqtt support to eKuiper #4155

Merged

Conversation

joshua-silverio
Copy link
Contributor

@joshua-silverio joshua-silverio commented Sep 14, 2022

Closes: #4147

Signed-off-by: intel joshua.silverio@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Can gen compose file with https://github.com/joshua-silverio/edgex-compose/tree/secure-ekuiper-mqtt

  • make gen dev ds-virtual mqtt-bus
  • make up
  • check kuiper container and app rules engine container to see the mqtt-bus connection success and flowing data
  • shell in to kuiper container and cat /kuiper/etc/sources/edgex.yaml to confirm usr/pass of mqtt-bus is configured correctly

New Dependency Instructions (If applicable)

Closes: edgexfoundry#4147

Signed-off-by: intel <joshua.silverio@intel.com>
@joshua-silverio joshua-silverio added security-services security-review Pull requests that require review by a member of the Security WG levski fall 2022 release labels Sep 14, 2022
@joshua-silverio joshua-silverio self-assigned this Sep 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell added this to QA/Code Review in Security WG Sep 14, 2022
@lenny-goodell lenny-goodell removed this from QA/Code Review in Security WG Sep 14, 2022
@lenny-goodell lenny-goodell removed security-services security-review Pull requests that require review by a member of the Security WG levski fall 2022 release labels Sep 14, 2022
Copy link
Collaborator

@bnevis-i bnevis-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see anything malicious or obviously wrong.

@joshua-silverio joshua-silverio merged commit b7de7b7 into edgexfoundry:main Sep 15, 2022
@joshua-silverio joshua-silverio deleted the secure-mqtt-eKuiper branch September 15, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure MQTT for eKuiper
3 participants