Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always run "kong migrations up" #4172

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

lenny-goodell
Copy link
Member

This ensures any missing migration are run and doesn't hurt if there are none. No need to run kong migrations list

fixes #4171

Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?) N/A
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?) N/A

Testing Instructions

Run Kamakura secure stack compose file
Get API Gateway token and verify API Gateway is functional
Stop (down) the services w/o clearing volumes
Run latest WIP secure stack compose file with Kong changed to version 2.8 and restart: always commented out.
Verify Kong remains running and the API Gateway is functional using the same token from the Kamakura stack
Stop (down) the services w/o clearing volumes
Run latest WIP secure stack compose file with Kong changed to version 2.8 and restart: always commented out.
Verify Kong still remains running and the API Gateway still is functional using the same token from the Kamakura stack

New Dependency Instructions (If applicable)

This ensures any missing migration are run and doesn't hurt is there are
none. Non need to run `kong migrations list`

fixes edgexfoundry#4171

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@lenny-goodell lenny-goodell merged commit f2edda9 into edgexfoundry:main Sep 29, 2022
@lenny-goodell lenny-goodell deleted the fix-kong-migrations branch September 29, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kong migrations don't run properly
3 participants