Skip to content
This repository has been archived by the owner on Apr 3, 2018. It is now read-only.

Validate event/reading value descriptors in export-distro #19

Open
chenchix opened this issue Feb 8, 2018 · 1 comment
Open

Validate event/reading value descriptors in export-distro #19

chenchix opened this issue Feb 8, 2018 · 1 comment

Comments

@chenchix
Copy link
Contributor

chenchix commented Feb 8, 2018

Fede and I were thinking about this feature and why it is in export distro instead of core-data, which is the entity that sends the messages.

In our understanding, core-data should send only valid messages and export only take care of filter, discard...

What do you think?

@feclare
Copy link
Contributor

feclare commented Feb 9, 2018

We have been looking at this and we would like to propose to implement it in data. We can check if the values are correct depending on their value descriptor and drop them without storing.

Some questions:

  • core-data had a flag (configuration.Metadatacheck) to drop events with invalid deviceId. Should the same flag be used to verify readings? Or it is better to create a new flag configuration.Readingcheck?
  • What happens to a event with an invalid reading and another valid? drop the whole event? drop one reading?
  • What happens to a event with an invalid reading? drop the whole event?
  • Should we move this issue to another repo (core-go or edgex-go)?

Any feedback @jpwhitemn ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants