Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Package Name Mismatch #46

Closed
tsconn23 opened this issue Mar 22, 2019 · 0 comments
Closed

Logging Package Name Mismatch #46

tsconn23 opened this issue Mar 22, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tsconn23
Copy link
Member

Note that the current https://github.com/edgexfoundry/go-mod-core-contracts/tree/master/clients/logging directory contains files that redefine their package as logger.

Example:

I have already fixed this locally and based on work to integrate into the other applications which depend on the logging, it appears the least invasive change to sync the names is to rename the logging directory to logger. This means imports in the consuming applications will need to change from

github.com/edgexfoundry/go-mod-core-contracts/clients/logging

to

github.com/edgexfoundry/go-mod-core-contracts/clients/logger

This is because applications are already using the logger name in most cases.
var LoggingClient logger.LoggingClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant