Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentacat implements Jason.Encoder for tuples #206

Open
davydog187 opened this issue Aug 3, 2021 · 2 comments
Open

Tentacat implements Jason.Encoder for tuples #206

davydog187 opened this issue Aug 3, 2021 · 2 comments

Comments

@davydog187
Copy link

davydog187 commented Aug 3, 2021

Hello 馃憢馃徏

I was taking a look at the source of tentacat, and noticed an issue.

Tentacat implements the Jason.Encoder protocol for tuples. This is problematic, as this will modify the behavior of the consuming application's Jason encoding outside of tentacat, which may not be desirable.

As a recommendation, users should either precompute their data, implement Jason.Encoder to the outer structure containing the tuple, or provide a hook for encoding.

@edgurgel
Copy link
Owner

edgurgel commented Aug 8, 2021

I agree! We shouldn't be implementing that 馃憤

@krisalyssa
Copy link

And yet, it still does....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants