Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/specification #22

Open
JostMueller opened this issue Nov 2, 2019 · 1 comment
Open

docs/specification #22

JostMueller opened this issue Nov 2, 2019 · 1 comment

Comments

@JostMueller
Copy link

I'm irritated about the example given section Canonical Representation
"codes":[
{
"name":"CMQ",
"description":"cubic centimetre,
"sector":"Space and time",
"quantity":"volume",
"symbol":"cm³",
"canonicalUnit":"MTQ",
"conversionFactor":10E-6
},
When referring to the columns in the Excel definition of Rec 20, the field "name" should be called "code" or "commonCode". This code's name is "Cubic centiemtere", the field "description" would be empty for CMQ, for MTQ it would contain "synonym: metre cubed".

An adjustment would require to modify the json original located at /rec20/codes.json and then adjust its reference in the docs.

@kshychko
Copy link
Contributor

kshychko commented Nov 4, 2019

@onthebreeze and @cmsdroff , could you please provide your comments on this issue? If we are going for #21 , we would need to provide explicit explanation why do we use a name property instead of code, otherwise it would raise questions like @JostFK raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants