Flush output after every line #17
Conversation
|
Hi @Jascha-N, Please look at the CONTRIBUTING.md I want you to execute Thanks, |
|
Already done. :) |
|
I will merge it as soon as I check it. |
Thanks. |
|
Actually, do not merge this yet. I did mess something up. |
|
@Jascha-N, |
|
@Jascha-N, |
|
I am going away for one hour. |
|
I'll try to fix it. I shouldn't have rushed it. I somehow thought I only removed legacy code. |
|
If I were you I would revert all my changes back and would add only required one. |
|
Should be fixed now. |
|
@Jascha-N, |
|
Well, it was not really the point of this PR, but I guess I can add it. |
|
I want you to do that because before your PR problems were printed to the "Problems" panel and a terminal at the same time. |
|
Really? Because I'm 99% sure all of the output was parsed in |
|
@Jascha-N, |
|
Alright, I'm almost done. |
|
Should the "Problems" panel be cleared before every cargo command? |
|
Yes, It should. |
|
I think it should work. |
| @@ -564,6 +551,8 @@ export class CommandService { | |||
| } | |||
|
|
|||
| private static createProject(isBin: boolean): void { | |||
| this.diagnostics.clear(); | |||
There was a problem hiding this comment.
There is no need for this since it is a project creation. We don't parse diagnostics here
|
@Jascha-N, |
|
|
||
| let onData = (data: string) => { | ||
| output += data; | ||
| errors = errors.concat(newErrors); |
There was a problem hiding this comment.
Are you sure this is more performant than
errors.push(...newErrors);
|
@Jascha-N, |
|
Done. |
|
Thank you. |
I've added the functionality for reading cargo output one line at a time and printing non-JSON lines to the output pane immediately. Another thing that would be nice is to have lines starting with "{" that fail parsing to still get printed, but it's not that important.
This is my first time working with TypeScript and Node.js, so I hope I didn't mess anything up.
Fixed #16.