Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for darwin-arm64 #187

Closed
joan-s-molas opened this issue Dec 1, 2021 · 5 comments
Closed

Support for darwin-arm64 #187

joan-s-molas opened this issue Dec 1, 2021 · 5 comments

Comments

@joan-s-molas
Copy link
Contributor

It would be nice to have support for darwin-amd64 in forthcoming releases - so the tool can run on newer macOS versions on Apple M1 silicon.

I have built 2.3.5, using go 1.17 (1.13 does not support darwin-arm64) and everything seems to work fine.

Please kindly consider adding support for that OS/architecture combination.

@mstruebing
Copy link
Member

Thank for your issue. This should definitely be supported.
I hope I find time soon to work on this.

@joan-s-molas
Copy link
Contributor Author

See if #188 can be helpful. There is a bit of a caveat though which is that darwin-386 support has been gone from go since 1.15

@mstruebing
Copy link
Member

Thank you very much.
I'm not sure about if we even need darwin-386 support, I think I was simply adding everything I was able to compile from my local machine to the Makefile so I think we can simply drop it.

@mstruebing
Copy link
Member

Can compile the target :)
I will - hopefully - prepare a new release later today.

Feel free to ping me again if I forget about it.

@mstruebing
Copy link
Member

🎉
https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants