Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run exclude regexp on absolute path #20

Closed
mstruebing opened this issue Dec 11, 2018 · 0 comments · Fixed by #24
Closed

Don't run exclude regexp on absolute path #20

mstruebing opened this issue Dec 11, 2018 · 0 comments · Fixed by #24
Labels
bug a bug which occured

Comments

@mstruebing
Copy link
Member

mstruebing commented Dec 11, 2018

Currently the regular expression of the default excludes are run on the whole absolute path but it should rather run on the relative path of the project root somehow.

For example for this repository, git would match (read exclude) all of this and much more (because of the github.com):

git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/Makefile
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/README.md
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/bin/ec
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/cmd/editorconfig-checker/main.go
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/cmd/editorconfig-checker/main_test.go
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/coverage.txt
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/docs/logo.png
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/pkg/types/types.go
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/pkg/utils/utils.go
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/pkg/utils/utils_test.go
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/pkg/validators/validators.go
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/pkg/validators/validators_test.go
git /home/maex/go/src/github.com/editorconfig-checker/editorconfig-checker.go/tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug a bug which occured
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant