Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslash/semicolon/octothorpe escaping (again) #6

Closed
xuhdev opened this issue Jun 20, 2019 · 12 comments
Closed

Backslash/semicolon/octothorpe escaping (again) #6

xuhdev opened this issue Jun 20, 2019 · 12 comments

Comments

@xuhdev
Copy link
Member

xuhdev commented Jun 20, 2019

This voting would be similar to #5 but is slightly different. #5 voted that we should not add backslash/semicolon/octothorpe escaping into EditorConfig specification before our specification requires to address this issue. Here are two follow-up questions:

  • Should we explicitly declare backslash/semicolon/octothorpe escaping undefined in the EditorConfig specification, or leave them unmentioned?
  • Should we remove the existing test case escaped_octothorpe_in_value, which tests octothorpe escaping?

Please vote by commenting below: yes or no only (e.g., yes, yes). Voting will be closed at the end of July 5.

Discussions please go to editorconfig/editorconfig-core-test#24

@editorconfig/board-member cc @rakus

@xuhdev
Copy link
Member Author

xuhdev commented Jun 20, 2019

yes,yes

@jednano
Copy link
Member

jednano commented Jun 20, 2019

yes,yes

@xuhdev
Copy link
Member Author

xuhdev commented Jun 23, 2019

Ping everybody again: @editorconfig/board-member

@johan
Copy link
Member

johan commented Jun 24, 2019 via email

@xuhdev
Copy link
Member Author

xuhdev commented Jun 24, 2019

Not a vote, just pointing out that the first question is ternary, not binary: the set of meaningful votes would be ”yes: state as undefined”, ”yes: leave out”, or ”no: no change”.

@johan The current status is leave out :) (i.e., no change == leave out)

@johan
Copy link
Member

johan commented Jun 24, 2019 via email

@sindresorhus
Copy link
Member

  1. Yes
  2. Yes

But we should ensure the issue is not forgotten for the formal grammar.

@rakus
Copy link

rakus commented Jun 26, 2019

Yes/Yes

@florianb
Copy link
Member

yes, yes

@xuhdev
Copy link
Member Author

xuhdev commented Jun 29, 2019

So the conclusion is yes, yes

@xuhdev xuhdev closed this as completed Jun 29, 2019
@editorconfig editorconfig locked as resolved and limited conversation to collaborators Jun 29, 2019
@xuhdev
Copy link
Member Author

xuhdev commented Jun 29, 2019

Test removed in editorconfig/editorconfig-core-test@2b983f5

@xuhdev
Copy link
Member Author

xuhdev commented Jun 30, 2019

Clarification added in editorconfig/specification@71e10b3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants