insert_final_newline = true and empty files

[ppalaga]

I wonder how an editorconfig processor should behave with insert_final_newline = true for an empty file? Should it (a) leave it as is or (b) should it add a line separator?

Background

My editorconfig-maven-plugin currently requires the line delimiter even in empty files and I got a user report claiming that the behavior is not compatible with some python tooling.

When searching for some editorconfig recommendations in this area, I just found a similar unresolved eclint issue jednano/eclint#156
So I guess there is no editorconfig-wide consensus about the matter.

Solution proposal

I understand the insert_final_newline as a means for enforcing files to comply with the POSIX definition of text file That definition explicitly says that it

allows a file with a single , or a totally empty file, to be called a text file.

So I think it should be OK to let an editorconfig processor to leave an empty file as is even with insert_final_newline = true

WDYT?

[cxw42]

I agree that a zero-byte file does not need a newline added to it.

[randstr]

Definitely option a) leave it as is. It's the only sensible behavior IMO.

[ppalaga]

Thanks, I went with the option (a) - leave empty files as they are.