Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle non-C/C++ plugins with the python core code #44

Open
xuhdev opened this issue Mar 27, 2012 · 6 comments
Open

bundle non-C/C++ plugins with the python core code #44

xuhdev opened this issue Mar 27, 2012 · 6 comments

Comments

@xuhdev
Copy link
Member

xuhdev commented Mar 27, 2012

By bundling non-C/C++ plugins with the python core code, users could avoid install the EditorConfig Core separately.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@treyhunner
Copy link
Member

This is a good idea if a Python interpreter is already installed. However, installing a Python interpreter just to use a plugin seems like more of a hassle than installing the C core.

I think this is a good idea for Gedit and Vim because it is implied that the user has a Python interpreter for use with those two plugins. I'm not sure about Emacs and jEdit plugins.

@xuhdev
Copy link
Member Author

xuhdev commented Mar 27, 2012

On Mar 28, 2012, at 0:05, Trey Hunnerreply@reply.github.com wrote:

This is a good idea if a Python interpreter is already installed. However, installing a Python interpreter just to use a plugin seems like more of a hassle than installing the C core.

I think this is a good idea for Gedit and Vim because it is implied that the user has a Python interpreter for use with those two plugins. I'm not sure about Emacs and jEdit plugins.

We just bundle the script, and the python script could be used if a python interpreter is present. But I believe we should use the C core (except vim and gedit) if the c executable is found.

@xuhdev
Copy link
Member Author

xuhdev commented Apr 3, 2012

Just like this, we could find an external python interp for a editor that does not support a built-in one. If a C core is missing and a python interp is found, we could take advantage of the python version, so user would feel more comfortable about the installation, since most Linux users have python installed by default.

@treyhunner
Copy link
Member

That could work well. Maybe for now we should look for editorconfig.py in addition to editorconfig in case they prefer install a Python package.

I don't think we should be too concerned with bundling the Python version with all of the plugins yet though. Our current solution works reasonably (even if it's not ideal) and for all I know there are currently no users of the jEdit or emacs plugins.

@xuhdev
Copy link
Member Author

xuhdev commented Apr 4, 2012

If a python version is bundled, users would be more likely to use EditorConfig with Emacs (and also jEdit, but I think emacs is more concerning).

OT: Maybe we should consider add the Emacs plugin to this site and this one

@xuhdev
Copy link
Member Author

xuhdev commented May 17, 2012

Done for vim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants